Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argparser edge case for value options which are a prefix of flags #8358

Closed
wants to merge 1 commit into from
Closed

Argparser edge case for value options which are a prefix of flags #8358

wants to merge 1 commit into from

Conversation

macneale4
Copy link
Contributor

@macneale4 macneale4 commented Sep 15, 2024 •
edited
Loading

This bug was preventing the diff --reverse flag from working properly. Not sure if this impacts other options, but it's pretty edgy.

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b5bf8b9 ok 5937457
version total_tests
b5bf8b9 5937457
correctness_percentage
100.0

@macneale4 macneale4 marked this pull request as ready for review September 15, 2024 18:48
@macneale4 macneale4 closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macneale4 @coffeegoddd