Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more issue related to the Adobe Commerce ( Magento ) installation. #7601

Closed
palamar opened this issue Mar 12, 2024 · 3 comments · Fixed by dolthub/vitess#319
Closed

One more issue related to the Adobe Commerce ( Magento ) installation. #7601

palamar opened this issue Mar 12, 2024 · 3 comments · Fixed by dolthub/vitess#319
Assignees
Labels
correctness We don't return the same result as MySQL customer issue good repro Easily reproducible bugs sql Issue with SQL

Comments

@palamar
Copy link

palamar commented Mar 12, 2024

MySql allows define primary key as constraint, and Magento uses CONSTRAINT PRIMARY KEY to simplify code generation.
But Dolt not allow such thin, so such SQL would generate error.

CREATE TABLE test (
  pk INT,
  col1 VARCHAR(255),
  CONSTRAINT PRIMARY KEY (pk)
);

erro
query error: Error parsing SQL: syntax error at position 73 near 'PRIMARY'.

@jycor jycor added sql Issue with SQL good repro Easily reproducible bugs correctness We don't return the same result as MySQL labels Mar 12, 2024
@jycor
Copy link
Contributor

jycor commented Mar 12, 2024

Hey @palamar, thanks for reporting this.
We'll get started on supporting this syntax for you!

@jycor
Copy link
Contributor

jycor commented Mar 12, 2024

Hey @palamar, the fix for this has been merged and is making its way through our pipeline.
Expect a release with the fix tomorrow!

@bpf120
Copy link

bpf120 commented Apr 1, 2024

Hi @palamar , thanks again for the issues. We'd love to learn more about your Dolt use case too. Feel free to join our Discord or send me an email if you'd like to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctness We don't return the same result as MySQL customer issue good repro Easily reproducible bugs sql Issue with SQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants