From 743eb87fce57242544a0f22b787698f9955dce06 Mon Sep 17 00:00:00 2001 From: Nick Tobey Date: Mon, 24 Feb 2025 19:32:02 -0800 Subject: [PATCH] Respond to PR comments. --- go/libraries/doltcore/sqle/tables.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/go/libraries/doltcore/sqle/tables.go b/go/libraries/doltcore/sqle/tables.go index 65166c0c46..bee2e81662 100644 --- a/go/libraries/doltcore/sqle/tables.go +++ b/go/libraries/doltcore/sqle/tables.go @@ -1686,13 +1686,11 @@ func (t *AlterableDoltTable) columnChangeRequiresRewrite(oldColumn *sql.Column, // TODO: we need to do this because some spatial type changes require a full table check, but not all. // We could narrow this check down. return true - } else if types.IsFormat_DOLT(t.Format()) { + } else { // This is overly broad, we could narrow this down a bit compatibilityChecker := typecompatibility.NewTypeCompatabilityCheckerForStorageFormat(t.Format()) typeChangeInfo := compatibilityChecker.IsTypeChangeCompatible(existingCol.TypeInfo, newCol.TypeInfo) return !typeChangeInfo.Compatible || typeChangeInfo.RewriteRows || typeChangeInfo.InvalidateSecondaryIndexes - } else if existingCol.Kind != newCol.Kind { - return true } }