From 1463a78a770e115e1dc3e4d7ad68e24fc16f94f6 Mon Sep 17 00:00:00 2001 From: Andreas Braun Date: Mon, 25 Nov 2019 20:34:20 +0100 Subject: [PATCH] Remove unneceesary internal designations --- lib/Doctrine/ODM/MongoDB/DocumentManager.php | 1 - .../MongoDB/PersistentCollection/PersistentCollectionTrait.php | 3 --- lib/Doctrine/ODM/MongoDB/UnitOfWork.php | 2 -- 3 files changed, 6 deletions(-) diff --git a/lib/Doctrine/ODM/MongoDB/DocumentManager.php b/lib/Doctrine/ODM/MongoDB/DocumentManager.php index 13cf2e039d..c5f5a6775c 100644 --- a/lib/Doctrine/ODM/MongoDB/DocumentManager.php +++ b/lib/Doctrine/ODM/MongoDB/DocumentManager.php @@ -283,7 +283,6 @@ public function getSchemaManager() * * @param string $className The class name. * @return \Doctrine\ODM\MongoDB\Mapping\ClassMetadata - * @internal Performance-sensitive method. */ public function getClassMetadata($className) { diff --git a/lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php b/lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php index 35d3f4ec98..62e863c40d 100644 --- a/lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php +++ b/lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php @@ -578,9 +578,6 @@ public function slice($offset, $length = null) /** * Called by PHP when this collection is serialized. Ensures that the * internal state of the collection can be reproduced after serialization - * - * @internal Tried to implement Serializable first but that did not work well - * with circular references. This solution seems simpler and works well. */ public function __sleep() { diff --git a/lib/Doctrine/ODM/MongoDB/UnitOfWork.php b/lib/Doctrine/ODM/MongoDB/UnitOfWork.php index 5fd6dcc4b9..9ab0b83d03 100644 --- a/lib/Doctrine/ODM/MongoDB/UnitOfWork.php +++ b/lib/Doctrine/ODM/MongoDB/UnitOfWork.php @@ -2047,7 +2047,6 @@ public function detach($document) * * @param object $document * @param array $visited - * @internal This method always considers documents with an assigned identifier as DETACHED. */ private function doDetach($document, array &$visited) { @@ -2697,7 +2696,6 @@ public function getClassNameForAssociation(array $mapping, $data) * @param array $hints Any hints to account for during reconstitution/lookup of the document. * @param object $document The document to be hydrated into in case of creation * @return object The document instance. - * @internal Highly performance-sensitive method. */ public function getOrCreateDocument($className, $data, &$hints = array(), $document = null) {