Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark classes internal that are internal #710

Closed
jwage opened this issue May 31, 2018 · 4 comments
Closed

Mark classes internal that are internal #710

jwage opened this issue May 31, 2018 · 4 comments
Assignees
Milestone

Comments

@jwage
Copy link
Member

jwage commented May 31, 2018

There really isn't much that the outside should be depending on in this library/tool so mark everything as @internal that nobody should be depending on.

@jwage jwage added this to the 2.0 milestone May 31, 2018
@jwage jwage self-assigned this May 31, 2018
@stof
Copy link
Member

stof commented May 31, 2018

well, I would say that the Tools/Console aprt should not be considered as internal, otherwise DoctrineMigrationsBundle reusing these commands to register them directly in the Symfony CLI would have to be considered as invalid (from the bundle perspective, we need to be able to rely on backward compatibility for these parts in non-major releases, and that means not being internal).
The Configuration part should also be considered public API (even the built-in runner still relies on receiving a configuration)

@jwage
Copy link
Member Author

jwage commented May 31, 2018

Yes, the commands, configuration, etc. wouldn't be considered internal.

@stof
Copy link
Member

stof commented May 31, 2018

well, the initial description says mark everything as @internal

@jwage
Copy link
Member Author

jwage commented May 31, 2018

Updated the description to be more accurate.

@jwage jwage closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants