Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse network-mode on CLI build #7689

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Parse network-mode on CLI build #7689

merged 1 commit into from
Aug 20, 2020

Conversation

ulyssessouza
Copy link
Collaborator

@ulyssessouza ulyssessouza commented Aug 19, 2020 •
edited
Loading

Parse network-mode when building with the native docker CLI

Resolves moby/buildkit#1642
Resolves #7682

@ulyssessouza
Parse network-mode on CLI build
6cebde7 
Signed-off-by: Ulysses Souza <[email protected]>
@ulyssessouza ulyssessouza requested a review from aiordache August 19, 2020 20:34
@ulyssessouza ulyssessouza mentioned this pull request Aug 19, 2020
Closed
aiordache
aiordache approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@aiordache aiordache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@aiordache aiordache merged commit c3f26bf into docker:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiordache aiordache aiordache approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof

@rumpl rumpl Awaiting requested review from rumpl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ulyssessouza @aiordache