Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading gw_priority #746

Merged
merged 3 commits into from
Feb 25, 2025
Merged

fix loading gw_priority #746

merged 3 commits into from
Feb 25, 2025

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Feb 23, 2025

Forgot to run make deepcopy - I always do adding new attributes. So I added a validation step to check this in CI, also updated make targets to run commands in a container vs local tools installation

closes docker/compose#12574

Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof force-pushed the gw_priority_fix branch 2 times, most recently from bd71318 to 51f5a25 Compare February 24, 2025 07:34
Signed-off-by: Nicolas De Loof <[email protected]>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 91e9c91 into compose-spec:main Feb 25, 2025
8 checks passed
@ndeloof ndeloof deleted the gw_priority_fix branch February 25, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] gw_priority not working
2 participants