From d6fa6da9675cdf78cdc2ff86487fec5710161e9a Mon Sep 17 00:00:00 2001 From: CrazyMax Date: Thu, 17 Mar 2022 14:19:56 +0100 Subject: [PATCH] bake: allow dot in target name Signed-off-by: CrazyMax (cherry picked from commit 8f61bfbbaa548eecce2f0b32c1e2ce37b8e87a0c) --- bake/bake.go | 2 +- bake/bake_test.go | 2 +- bake/compose_test.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bake/bake.go b/bake/bake.go index 82d7d921bc27..464078b9371d 100644 --- a/bake/bake.go +++ b/bake/bake.go @@ -28,7 +28,7 @@ var ( httpPrefix = regexp.MustCompile(`^https?://`) gitURLPathWithFragmentSuffix = regexp.MustCompile(`\.git(?:#.+)?$`) - validTargetNameChars = `[a-zA-Z0-9_-]+` + validTargetNameChars = `[a-zA-Z0-9._-]+` targetNamePattern = regexp.MustCompile(`^` + validTargetNameChars + `$`) ) diff --git a/bake/bake_test.go b/bake/bake_test.go index 9864e85b0249..b819190d9cc7 100644 --- a/bake/bake_test.go +++ b/bake/bake_test.go @@ -1011,7 +1011,7 @@ func TestTargetName(t *testing.T) { }, { target: "a.b", - wantErr: true, + wantErr: false, }, { target: "_a", diff --git a/bake/compose_test.go b/bake/compose_test.go index fffd97b0f9b1..35587d6c48f9 100644 --- a/bake/compose_test.go +++ b/bake/compose_test.go @@ -330,7 +330,7 @@ func TestServiceName(t *testing.T) { }, { svc: "a.b", - wantErr: true, + wantErr: false, }, { svc: "_a",