Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"id" "createdAt" "updatedAt" not returned #2

Open
anishkny opened this issue Nov 28, 2019 · 6 comments
Open

"id" "createdAt" "updatedAt" not returned #2

anishkny opened this issue Nov 28, 2019 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@anishkny
Copy link

See: gothinkster/realworld#444

@dnikolovv
Copy link
Owner

Thank you. I'll fix that.

@dnikolovv dnikolovv added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 11, 2019
@dmytrohridin
Copy link
Contributor

@anishkny
I'm looking at https://github.com/gothinkster/realworld/tree/master/api and can not find this fields in user response documentation. If we need this fields in backend - can we specify them in api documentation. Because not only this api do not return this fields for user.
Thank you

@anishkny
Copy link
Author

Not on user, just on article and comment.

@dmytrohridin
Copy link
Contributor

oh, okay
because in issue seems described Register User action

@anishkny
Copy link
Author

my bad, you are correct - the issue does seem to talk about id, createdAt, updatedAt on user object. This is a discrepancy between API docs and production API

@dmytrohridin
Copy link
Contributor

so do we need this fields in user or not? because if yes - all backend repositories should be updated I believe 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants