Secret Change Review w/ JsonDiffPatch

[tallpauley]

I think it'd be great to have an option for an additional modal after editing a secret or policy (or any JSON for that matter) that shows a diff of the changes w/ jsondiffpatch.

The option would also change the edit modal's "SUBMIT" text to "REVIEW", and then the following modal with the diff would have "CANCEL" and "SUBMIT".

I think this would be a nice option to limit potential dangerous mistakes. I might have some time to work on this one soon, it's a building block for my use case of vault as a decent UI password manager.

[msessa]

interesting idea. would like to see it implemented

[Lucretius]

Found this gathering dust at the bottom of the issue bin and decided to have a go at it.

I've created a branch with the following:

If no difference is found you just get

Someone was kind enough to port the jsondiffpatch into React with some annotated JSON viewer. I've included a toggle so you can show and hide as desired. I've opted to place the differ within the JsonEditor component itself, as the diffing mechanism is tied directly to the editor.

I will have a PR up soon.

[tallpauley]

lgtm, lets close this since the PR was already merged