Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Add Favicon #178

Closed
rosspeoples opened this issue Aug 30, 2017 · 4 comments
Closed

Add Favicon #178

rosspeoples opened this issue Aug 30, 2017 · 4 comments
Labels

Comments

@rosspeoples
Copy link
Contributor

I know this is super low priority and somewhat silly, but can we add a favicon? I typically have a bunch of browser tabs open and the tab for Vault-UI can easily get lost since, in Chrome at least, it defaults to using an icon of a curled piece of paper. Having a pretty icon on the tab would improve the UX a bit.

@djenriquez
Copy link
Owner

Hmmm we do have a favicon though. It looks like its probably unable to find it, meanwhile my browser has had it cached all this time. I'll dig in later today, thanks for catching this.

@djenriquez djenriquez added the bug label Aug 30, 2017
@tallpauley
Copy link
Collaborator

@djenriquez any progress on this? vault-ui points to /favicon.ico which isn't a thing. https://www.vaultproject.io/ has a small and large icon, and a number of platform specific icons (which I don't think we'd need to bother with).

@djenriquez djenriquez mentioned this issue Sep 23, 2017
@djenriquez
Copy link
Owner

Yup, @msessa generously built us a favicon a while back, just had bad references, this fixes it (#188).

@djenriquez
Copy link
Owner

Closing via #188.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants