Fixed broken footer links that show 404 page. #1937
Conversation
garybadwal
changed the title
|
Hi @sarahboyce, sorry to disturb you, but it would be helpful if you could review this for once. |
| <li><a href="https://django.threadless.com/" target="_blank">Official merchandise store</a></li> | ||
| <li><a href="/foundation/donate/#benevity-giving">Benevity Workplace Giving Program</a></li> | ||
| <li><a href="{% url 'homepage' %}foundation/donate/#benevity-giving">Benevity Workplace Giving Program</a></li> |
There was a problem hiding this comment.
| <li><a href="{% url 'homepage' %}foundation/donate/#benevity-giving">Benevity Workplace Giving Program</a></li> | |
| <li><a href="{% url 'fundraising:index' %}#benevity-giving">Benevity Workplace Giving Program</a></li> |
| @@ -57,9 +57,9 @@ <h2>Follow Us</h2> | |||
| <h2>Support Us</h2> | |||
| <ul> | |||
| <li><a href="{% url "fundraising:index" %}">Sponsor Django</a></li> | |||
| <li><a href="/foundation/corporate-membership/">Corporate membership</a></li> | |||
| <li><a href="{% url 'homepage' %}foundation/corporate-membership/">Corporate membership</a></li> | |||
There was a problem hiding this comment.
| <li><a href="{% url 'homepage' %}foundation/corporate-membership/">Corporate membership</a></li> | |
| <li><a href="{% url 'members:corporate-members' %}">Corporate membership</a></li> |
Sure, I'll fix this thank you for your reviews. |
Hi Sarah, Are there any changes in the main branch? it also don't show me these 2 links:
|
|
I think they are coming from flatpages and so we don't have the data locally. I think you can leave them as they are (we might want to make a fixture for these in future) |
Ok, Then for now can we consider this PR as a fix? Until you make the fixtures for this? |
The previous suggestions I gave are still valid, I have tested locally 👍 |
Ok got it. If you can give me a lead in this I can update this PR. |
|
Hi @sarahboyce, sorry to disturb you just checking if you can help me with the next step in this? |
|
I think the suggested line changes are still valid, and are unrelated to flatpages. I have commented on each |
Closes: #1880
The broken link issue that occurs when a user clicks on the foundation links that are statically provided in the footer section of https://docs.djangoproject.com/ has been fixed. This update will resolve the problem without affecting the way things really work.