Updated Indian states and union territories names and code #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I am a beginner in contributing to open source projects. This is my first PR |
2 tasks
benkonrath
requested changes
Feb 19, 2021
| @@ -15,6 +15,7 @@ New fields for existing flavors: | |||
| Modifications to existing flavors: | |||
|
|
|||
| - Fix `FRNationalIdentificationNumber` validation for people born overseas | |||
| - Updated Indian states and union territories names and code as per iso 3166 (https://www.iso.org/obp/ui/#iso:code:3166:IN) | |||
There was a problem hiding this comment.
This change will break some sites since some keys are changing or being removed. We try to follow the standards so this change is ok but it should be documented. All keys that have changed or have been removed should be listed in the changelog entry. I wrote this up quickly:
Breaking data changes: The key for Chattisgarh has been changed from CG to CT, the key for Uttarakhand has been changed from UA to UT and the keys DD (Dadra and Nagar Haveli) and DN (Daman and Diu) hav been remove and combined into DH (Dadra and Nagar Haveli and Daman and Diu).
Could you double check that it makes sense and add it to the changelog? Thanks!
There was a problem hiding this comment.
@benkonrath Thank you for the review. I have added all the changes in the changelog as you suggested. Kindly let me know if I need to add anything further.
…tates and union territories as per iso 3166
benkonrath
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Indian states and union territories names and code as per iso 3166 (https://www.iso.org/obp/ui/#iso:code:3166:IN)
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.