Fix French national identification number validation with people born overseas #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that localflavor does not allow the entry of NIR with
98
as the birth department, excluding it because98
would correspond to Monaco.In fact,
98
is used for "COM" (eg. French Polynesia, Wallis and Futuna, New Caledonia) and people born in Monaco would have99
asdepartment_of_origin
and138
ascommune_of_origin
(99
stands for a birth abroad and138
is the INSEE code for Monaco).This codification is a real mess, I've attached two official INSEE documents, which are more complete and reliable sources than Wikipedia (page 6 is a good summary).
This fix add the following changes:
[971-976]
->[971-978]
)[984-989]
)99
)INSEE Guide identification.pdf
INSEE Codes Pays.pdf