Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localflavor-it: wrong error string in ITSocialSecurityNumberField #164

Closed
zarelit opened this issue Aug 14, 2015 · 5 comments
Closed

localflavor-it: wrong error string in ITSocialSecurityNumberField #164

zarelit opened this issue Aug 14, 2015 · 5 comments

Comments

@zarelit
Copy link

zarelit commented Aug 14, 2015

The original error string in it/forms.py is "Enter a valid Social Security number." that is literally translated in the Italian language file.

While this is good for the same string in another context (e.g. the Mexican forms.py) it has the wrong meaning if used in Italian applications; the error string should be something like "Enter a valid Fiscal Code" or "Inserisci un Codice Fiscale valido".

The string "Inserisci un numero di Assistenza Sociale valido" cannot be understood by Italian non English-speaking people.

@claudep
Copy link
Member

claudep commented Aug 15, 2015

@yakky, @pauloxnet, would you support using "Enter a valid Fiscal Code" in this error message?

@zarelit
Copy link
Author

zarelit commented Aug 15, 2015

I've actually found that "Agenzia Delle Entrate" (Italian revenue agency) actually calls it "Tax Code" in their English documents.
http://www1.agenziaentrate.gov.it/english/italian_taxation/tax_code.htm

I would use "Enter a valid Tax code" in the source and "Inserisci un Codice Fiscale valido" as the Italian translation

@yakky
Copy link
Contributor

yakky commented Aug 15, 2015

@zarelit @claudep Above PR should fix the error message. The italian translation must be fixed on transifex after merging

@zarelit
Copy link
Author

zarelit commented Aug 15, 2015

@yakky As you wish, they're almost the same, except that yours changes the string in the .po file and makes the comment more clear. I would go for yours.

@yakky
Copy link
Contributor

yakky commented Aug 15, 2015

@zarelit we've been both quite quick ! Thanks @claudep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants