From a8e0edf2f983505bfdccadba5c447607a3c5eb35 Mon Sep 17 00:00:00 2001 From: Alex Boten Date: Wed, 4 May 2022 09:38:46 -0700 Subject: [PATCH] [chore] use Remove instead of Delete (#9732) This is a followup to https://github.com/open-telemetry/opentelemetry-collector/commit/9be6eccafb94b9a52f0dfc39216cb60855d636cc --- pkg/translator/jaeger/jaegerthrift_to_traces.go | 4 ++-- receiver/kafkametricsreceiver/consumer_scraper.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/translator/jaeger/jaegerthrift_to_traces.go b/pkg/translator/jaeger/jaegerthrift_to_traces.go index 807b6a679168..b69ad52dc3e1 100644 --- a/pkg/translator/jaeger/jaegerthrift_to_traces.go +++ b/pkg/translator/jaeger/jaegerthrift_to_traces.go @@ -110,7 +110,7 @@ func jThriftSpanToInternal(span *jaeger.Span, dest ptrace.Span) { setInternalSpanStatus(attrs, dest.Status()) if spanKindAttr, ok := attrs.Get(tracetranslator.TagSpanKind); ok { dest.SetKind(jSpanKindToInternal(spanKindAttr.StringVal())) - attrs.Delete(tracetranslator.TagSpanKind) + attrs.Remove(tracetranslator.TagSpanKind) } // drop the attributes slice if all of them were replaced during translation @@ -163,7 +163,7 @@ func jThriftLogsToSpanEvents(logs []*jaeger.Log, dest ptrace.SpanEventSlice) { jThriftTagsToInternalAttributes(log.Fields, attrs) if name, ok := attrs.Get(tracetranslator.TagMessage); ok { event.SetName(name.StringVal()) - attrs.Delete(tracetranslator.TagMessage) + attrs.Remove(tracetranslator.TagMessage) } } } diff --git a/receiver/kafkametricsreceiver/consumer_scraper.go b/receiver/kafkametricsreceiver/consumer_scraper.go index a73e0618bbd9..43576521082d 100644 --- a/receiver/kafkametricsreceiver/consumer_scraper.go +++ b/receiver/kafkametricsreceiver/consumer_scraper.go @@ -162,7 +162,7 @@ func (s *consumerScraper) scrape(context.Context) (pmetric.Metrics, error) { } addIntGauge(ilm.Metrics(), metadata.M.KafkaConsumerGroupLag.Name(), now, labels, consumerLag) } - labels.Delete(metadata.A.Partition) + labels.Remove(metadata.A.Partition) addIntGauge(ilm.Metrics(), metadata.M.KafkaConsumerGroupOffsetSum.Name(), now, labels, offsetSum) addIntGauge(ilm.Metrics(), metadata.M.KafkaConsumerGroupLagSum.Name(), now, labels, lagSum) }