Clarify CSS parameters in <context> #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… had problems understanding this part when I first started tinkering with plugins. I may be a bit too detailed...
infotexture
changed the title
infotexture
added
enhancement
|
@lionelmoi 👍 Thanks for submitting. I think it makes sense to add more context for these parameters, and did something similar in the topic on Setting parameters for custom HTML. I'll merge this as is, and then combine your suggestions with the information in that topic and push the extra explanations to the Parameter Reference topic on HTML-based output parameters so they're also available in that context. |
|
Sounds great to me. I also refactored some content in Setting parameters for custom HTML (see #123). If you are okay with the refactoring we may want to link to the sub-tasks in the HTML-based output parameters. |
infotexture
approved these changes
Dec 5, 2016
infotexture
added a commit
that referenced
this pull request
Dec 5, 2016
Per #122. Signed-off-by: Roger Sheen <[email protected]>
infotexture
added a commit
that referenced
this pull request
Dec 5, 2016
Per #122. Signed-off-by: Roger Sheen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added precisions to context for newbies (as a former noob)
I added a few precisions to the list in the context section. I know I had problems understanding this part when I first started tinkering with plugins.
I may be a bit too detailed...