Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition causing .status.accessmessage to not be setup #46

Merged
merged 14 commits into from
Nov 29, 2022

Conversation

diranged
Copy link
Owner

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code repo labels Nov 29, 2022
@diranged diranged force-pushed the faster_build branch 2 times, most recently from 18eb764 to 80844c8 Compare November 29, 2022 15:54
@coveralls
Copy link

coveralls commented Nov 29, 2022

Pull Request Test Coverage Report for Build 3576453814

  • 25 of 60 (41.67%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 37.055%

Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/pod_access_request_controller.go 4 5 80.0%
controllers/exec_access_request_controller.go 0 2 0.0%
controllers/builders/exec_access_builder.go 0 8 0.0%
controllers/base_controller.go 12 24 50.0%
controllers/builders/pod_access_builder.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/exec_access_request_controller.go 1 0%
Totals Coverage Status
Change from base Build 3570743226: -0.5%
Covered Lines: 614
Relevant Lines: 1657

💛 - Coveralls

@diranged diranged merged commit 3035f5e into main Nov 29, 2022
@diranged diranged deleted the faster_build branch November 29, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants