feat: add support for Argo Rollouts resource

[dnguy078]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 5904758774

• 0 of 24 (0.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 45.784%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/builders/utils/get_selector_labels.go	0	7	0.0%
internal/builders/utils/get_pod_template_from_controller.go	0	8	0.0%
internal/builders/utils/get_rollout.go	0	9	0.0%

Totals
Change from base Build 5896086499:	-0.5%
Covered Lines:	972
Relevant Lines:	2123

---

💛 - Coveralls

[dnguy078]

I wasn't sure how to add this CRD via kustomize. Wondering if there was a way to autogenerate this into bases folder?

[diranged]

This directory is managed by the operator code and should only ever have auto-generated code. I believe you want to modify the test framework itself: https://v0-18-x.sdk.operatorframework.io/docs/golang/unit-testing/#testing-with-3rd-party-resources

[dnguy078]

I tried to write test to create a Rollout object and then create a PodAccessTemplate pointing to the Rollout and PodAccessRequest.

 failed to get API group resources: unable to retrieve the complete list of server APIs: argoproj.io/v1alpha1: the server could not find the requested resource

I read through the docs for this and tried to apply this but it seems that the cluster itself does not know what a Rollout object is when the client attempts to create it.

A workaround was to manually add the crd to the crd base path or maybe add the crd through a e2e test suite ?
https://github.com/diranged/oz/blob/main/internal/builders/podaccessbuilder/suite_test.go#L62.
I wasnt sure if theres other options ?

@diranged

[diranged]

This directory is managed by the operator code and should only ever have auto-generated code. I believe you want to modify the test framework itself: https://v0-18-x.sdk.operatorframework.io/docs/golang/unit-testing/#testing-with-3rd-party-resources

[diranged]

@dnguy078 Can you add tests?

[diranged]

@dnguy078 Does https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/using_an_external_type.md help?

[dnguy078]

@dnguy078 Does https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/using_an_external_type.md help?

Not necessarily, this would require using Go's old vendoring folder and referencing the crd yaml file through there. This implies that crd.yaml is placed in a folder that has an exportable go package. Argo Rollout places their crds into a folder that has no go files https://github.com/argoproj/argo-rollouts/tree/master/manifests so we can't simply vendor this in as well.
@diranged

[dnguy078]

I ended up using go mod download to be able to grab the crds from rollouts. Unable to use vendor since the crd files were place into a folder without go files.

I ended up using a mixture the approach of adding the CRD into the envtest.Environment in https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/using_an_external_type.md#prepare-for-testing. Unable to find much documentations on standards to test with third party operators beyond this. also referenced. It would be nice if operators exposed a CustomResourceDefinition struct like this.

[diranged]

one comment, then i think it looks good

[diranged]

Let's add this direectory to .gitignore

[dnguy078]

this directory is outside of the repo project and its installed as part of the $GOPATH/pkg via the go mod @diranged