Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of pre-build events lead to occasional race condition during solution build #9

Open
ronnieholm opened this issue May 23, 2020 · 2 comments

Comments

@ronnieholm
Copy link
Contributor

In case execution of pre-build events for IdP and SP overlap, compilation may intermittently fail. Failure is caused by parallel execution of appcmd processes. Execution of appcmd in IdP races execution of appcmd in SP, leading to "file applicationhost.config locked by other process" compilation error.

In principle, I don't believe there's a need for pre-build events. appcmd setup is only needed once. I suppose the pre-build events were added in order to avoid additional manual steps about first opening the solution in Visual Studio (triggering .vs folder creation), then executing appcmd.

@ronnieholm
Copy link
Contributor Author

Appears fixed by @mdbech in 4b3fd31.

Closing this issue.

@ronnieholm
Copy link
Contributor Author

On second look, I don't believe the precondition added to the pre-build event solves this problem. Two instances of appcmd can still overlap causing intermittent build failure, especially on slower machines.

@ronnieholm ronnieholm reopened this Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant