Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build.rs fails when building with -Z build-std #30

Open
ubamrein opened this issue Jul 29, 2021 · 1 comment
Open

Build.rs fails when building with -Z build-std #30

ubamrein opened this issue Jul 29, 2021 · 1 comment

Comments

@ubamrein
Copy link

The autocfg probe function compiles sample code to the specified target to probe for i128 support. This fails when we try to use the crate with a target which does not have pre-built std-libraries and hence build it from scratch with the unstable build-std feature. I wonder if we could add an environment variable to just skip this check, or if there is any other way to check for i128 support (is it really only compiler version dependent? if so would a rustc --version be sufficient?).

I can gladly try to submit a pull-request, as I currently have the situation to test if the fix would work, but just wanted to ask for the right direction.

@dignifiedquire
Copy link
Owner

we probably can just drop the probe, as the MSRV is now high enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants