Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing dashes for contact list #3408

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix missing dashes for contact list #3408

wants to merge 1 commit into from

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Feb 6, 2025

Short description

This PR adds the minus icon to the contact list for information that hasn't been filled out.

Proposed changes

  • Add dashes / minus icon to empty fields
  • Adjust some paddings
  • Add fallback link for website (fallback is to direct to contact form as for all other fields too)

Side effects

  • This PR still might be expanded to other content types (or this might be done in another PR)

Resolved issues

Fixes: #3397

Pull Request Review Guidelines

charludo
charludo approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks very nice! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charludo charludo charludo approved these changes

@PeterNerlich PeterNerlich Awaiting requested review from PeterNerlich

@MizukiTemma MizukiTemma Awaiting requested review from MizukiTemma

@jonbulz jonbulz Awaiting requested review from jonbulz

@jarlhengstmengel jarlhengstmengel Awaiting requested review from jarlhengstmengel

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty columns should contain "-" and should be clickable
2 participants
@JoeyStk @charludo