Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notifications are sent before news item is delivered by the API #3378

Open
steffenkleinle opened this issue Jan 29, 2025 · 2 comments
Open
Labels
bug Something isn't working

Comments

@steffenkleinle
Copy link
Member

Describe the Bug

At the moment, the push notification is immediately sent to users. However, the local news endpoint does not immediately include the new news item. If I click on the push notification, I am greeted with a not found error message in the app (as the api does not include the news item yet).

The push notification should only be sent once the news item is available in the API.

Maybe this is primarily an test cms issue though as it was not yet reported by anyone.

Steps to Reproduce

  1. Go to https://cms-test.integreat-app.de/testumgebung/push-notifications/de/
  2. Send a push notification
  3. Immediately click on the push notification in the native app
  4. See error

Expected Behavior

The push notification is not sent before the news are ready in the api.

Actual Behavior

The push notification is sent before the news are ready in the api.

Additional Information

In the app we already make use of 1 second, but this does not seem to be enough.

Related Issues

N/A

@steffenkleinle steffenkleinle added the bug Something isn't working label Jan 29, 2025
@osmers
Copy link

osmers commented Jan 29, 2025

@steffenkleinle I just tested this on production and it works without a problem - but makes sense to keep it in mind and test it after the next release, right?

@steffenkleinle
Copy link
Member Author

steffenkleinle commented Jan 29, 2025

@steffenkleinle I just tested this on production and it works without a problem - but makes sense to keep it in mind and test it after the next release, right?

Hmm, interesting. Then it is maybe actually just a problem in the test cms due to less resources/computing power here?
Perhaps the order should still be fixed here (i.e. first saving and making sure the api is ready and only then push notification), but has no high prio at all. But feel free to just close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants