Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3028: Show user icon after robot message in Chat #3078

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

3028: Show user icon after robot message in Chat #3078

wants to merge 1 commit into from

Conversation

hannaseithe
Copy link
Contributor

Short Description

I added a condition to check whether between two messages the _automaticAnswer status changed. Now if a human answers after a bot (or vice versa) we will show the human icon (or the bot icon) after the switch.

Proposed Changes

  • I added a second OR condition to show the message's human icon when a human writes directly (from zammad) after the bot (or vice versa)
  • I kept the original condition of always showing the icon for every message after isUserAuthor changes

Side Effects

  • affects ChatMessage

Testing

  • there should be on icon showing both from the switch between human to bot and bot to human
  • the original Icon showing behavior should be not changed (showing an icon every time we switch between author and human/bot from zammad)

Fixes: #3028

@hannaseithe
Copy link
Contributor Author

I forgot to add unit tests. Will do so now. Please wait before review

@steffenkleinle
Copy link
Member

I forgot to add unit tests. Will do so now. Please wait before review

Thanks for thinking of that :) Feel free to just mark the PR as Draft. You can do so in the top right:
image

@hannaseithe hannaseithe marked this pull request as draft February 11, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

@f1sh1918 f1sh1918 Awaiting requested review from f1sh1918 f1sh1918 is a code owner

@LeandraH LeandraH Awaiting requested review from LeandraH LeandraH is a code owner

@bahaaTuffaha bahaaTuffaha Awaiting requested review from bahaaTuffaha bahaaTuffaha is a code owner

@lunars97 lunars97 Awaiting requested review from lunars97 lunars97 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zammad user messages are summarized with robot icon
2 participants
@hannaseithe @steffenkleinle