Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is a Shockwave Flash SWF file included and then triggering macOS ransomewhere alerts? #843

Open
OKNoah opened this issue Jan 15, 2021 · 7 comments

Comments

@OKNoah
Copy link

OKNoah commented Jan 15, 2021

Screen Shot 2021-01-14 at 4 58 21 PM

This is after doing npx expo install.

@davidlehn
Copy link
Member

I'm not sure what that warning image is even saying. Is it saying node locked those files? What does that mean in this case? Just a regular file lock or is this tool saying it's doing something evil? Does that even have anything to do with the files that are being locked like the swf?

That old flash support was there to do raw socket connections in a browser. Now that flash has fallen out of favor, it's not of much use anymore.

Assuming the swf file hasn't been modified, it should be safe. The 4+ year old code and prebuilt swf are available in the flash/ dir. You could rebuild it yourself if the toolchain still works.

You might want to contact your scanner vendor and ask them why this is happening.

@OKNoah
Copy link
Author

OKNoah commented Jan 16, 2021

I assumed this was macOS, but maybe ReiKey or Clamxav

@mehboob-alam81
Copy link

Any update? Adobe has sunset Flash for security risk. Any reason why this module still exists/needed?
https://www.adobe.com/products/flashplayer/end-of-life.html
.."After the EOL Date, Adobe will not issue Flash Player updates or security patches. Adobe strongly recommends immediately uninstalling Flash Player. To help secure your system, Adobe blocked Flash content from running in Flash Player beginning January 12, 2021. Major browser vendors have disabled and will continue to disable Flash Player from running."

@SMBurrows
Copy link

+1
detected SocketPool.swf as a Trojan

1 similar comment
@mohiteng
Copy link

+1
detected SocketPool.swf as a Trojan

@yeukhon
Copy link

yeukhon commented Jan 25, 2023

@davidlehn would you be open if I create a PR and drop the support of this entirely? I think many enterprise security monitoring tools generally flag these. I'd rather not to fork and maintain this as node-forge is used by popular tools like webpack server.

@davidlehn
Copy link
Member

There is no trojan or malicious code here at all. It's a shame that security scanner tools are buggy and think there are issues. That being said, I suppose it is time to drop the flash bits. Hard to tell if anyone still uses the flash support. I assume very few projects, if any, still do. I think the way to update is to leave the flash files in the source repo, stop shipping in the npm package, update docs and so on explaining the issue, and release a major update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants