Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict available commands so that 'digger apply' does not apply to Prod #841

Open
ZIJ opened this issue Dec 1, 2023 · 1 comment
Open
Labels
enhancement New feature or request user-reported

Comments

@ZIJ
Copy link
Contributor

ZIJ commented Dec 1, 2023

In case of multiple environments, digger apply comment will attempt to apply all of them, including prod. Specifying -p option doesn't solve it because it relies on user being conscious about it.

Prosposed solution

Allow specifying allowed_commands in the workflow file. If there are multiple workflow files (for different environments) then it will prevent apply from running even if user adds comments trigger by mistake.

@ahuseby
Copy link

ahuseby commented Mar 11, 2024

I have another suggestion, that's maybe its own issue/feature request, but I think it relates anyway:

If at all possible, add support for integrating Digger projectects with GitHub repo envirionments and set deployment status based on all the environment's related projects have finished deploying (from e.g. "digger deploy dev").

So the idea in this case is that an environment does not necessarily equal to one, and only one, project. Rather several projects could be part of the same environment.

projects:
  # Dev Projects
  - name: network_dev
    dir: dev/network
    github_environment: dev
  - name: app_dev
    dir: dev/app
    github_environment: dev

  # Prod Projects
  - name: network_prod
    dir: prod/network
    github_environment: prod
  - name: app_prod
    dir: prod/app
    github_environment: prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user-reported
Projects
None yet
Development

No branches or pull requests

3 participants