Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option parsing in java_bytecode_language #743

Open
reuk opened this issue Mar 31, 2017 · 1 comment
Open

Option parsing in java_bytecode_language #743

reuk opened this issue Mar 31, 2017 · 1 comment

Comments

@reuk
Copy link
Contributor

reuk commented Mar 31, 2017

One of the options parsed by java_bytecode_language is required after the instance of this object has left scope. Under the current scheme, this option cannot be made available. Changes are required so that parsed options are available after the languaget instance has left scope.

The get_language_options method on languaget has no implementation, and is only overridden by java_bytecode_languaget. In the discussion on #691, it was suggested that

Option parsing from cmdlinet to optiont should be done with the rest of the parse_option code (in the application directory), not in the front-end.

I recommend that the get_language_options method be removed, and its contents from java_bytecode_language be moved to a more appropriate location in the parse_option code.

@martin-cs
Copy link
Collaborator

This sounds like the right direction to go. The *_parse_option code should own the option object, populate it from cmdline and hold on to it for the duration of the program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants