-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Drop Jansi since Windows 10 now supports ANSI escape codes #25
Comments
The Windows 10 feature that allows ANSI color codes is named "Virtual Terminals" (source) That feature is not enabled by default, there are a few viable solutions to that:
This |
Weird thing, I executed the It's been a year since that feature was released, so maybe now it's ON by default |
I had to go with JCDP responsibility -- we make a native Win10 call to enable the feature (once per execution), to solve PowerShell/PowerShell#11449 |
I read that Windows 10 now supports ANSI escape codes natively. (sources: 1, 2)
We currently depend on Jansi precisely because it allowed us to bypass that limitation on Windows. If that's no longer the case, we can drop that dependency. Even better, we can merge our current
NixColoredPrinter
andWinColoredPrinter
into a single class!The text was updated successfully, but these errors were encountered: