Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear signal requestID on workflow close #429

Open
dhiaayachi opened this issue Sep 5, 2024 · 1 comment
Open

Clear signal requestID on workflow close #429

dhiaayachi opened this issue Sep 5, 2024 · 1 comment

Comments

@dhiaayachi
Copy link
Owner

Is your feature request related to a problem? Please describe.
Signal requestID is for dedupping signal request. After workflow close, all signal requests will be rejected, so we don't really need signal requestIDs for dedupping.

Describe the solution you'd like

Describe alternatives you've considered

  • We don't have to do it if we believe we won't benefit much from making this change.

Additional context
Add any other context or screenshots about the feature request here.

@dhiaayachi
Copy link
Owner Author

Thank you for your feature request! This is a great idea and would definitely be useful for many users.

While we don't have a specific plan to implement this feature right now, you can work around it by persisting the signal request ID as part of the signaled event. This way, upon reset, the signal request ID map can be rebuilt.

Let me know if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant