You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is auto-generated from hashicorp#20417 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.
The person who merged in the original PR is: @hashi-derek
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
A regression was introduced in hashicorp#19954 where the SAN validation matching was reduced from 4 potential types down to just the URI.
Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped match_subject_alt_names Envoy behavior, we should match on all 4 enum types.
Backport
This PR is auto-generated from hashicorp#20417 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
The person who merged in the original PR is:
@hashi-derek
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Fixes issue: hashicorp#20360
A regression was introduced in hashicorp#19954 where the SAN validation matching was reduced from 4 potential types down to just the URI.
Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped
match_subject_alt_names
Envoy behavior, we should match on all 4 enum types.https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype
Overview of commits
The text was updated successfully, but these errors were encountered: