fix: Lambda timeout status code #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dnalborczyk Only one test is failing. Is this related to the change? I tested it locally and tests are passing (even with node 18 on macos) |
|
thank you for the PR @DorianMazur . give me a couple days to have a look.
some of the tests can be a bit flaky at times. I re-ran the failed one. |
|
@dnalborczyk Thanks! It's working now |
|
@dnalborczyk it could be useful in my project, did you have a chance to review it already ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
serverless-offlinereturns wrong status code when timeout occurs. Instead of502, it should return504.This pull request fixes this issue.
Motivation and Context
According to serverless docs, it should be
504.https://github.com/serverless/serverless/blob/main/test/integration/aws/api-gateway.test.js#L226
How Has This Been Tested?
At the moment I have tested against our own project which already specified a lambda.
The majority of the code has been untouched so it should work.