From 0966e6185aa29ec0e88271bc983b81933334acaa Mon Sep 17 00:00:00 2001 From: Vibhatha Lakmal Abeykoon <vibhatha@users.noreply.github.com> Date: Fri, 5 Jan 2024 20:49:07 +0530 Subject: [PATCH] MINOR: [Java] Bump com.google.errorprone:error_prone_core from 2.4.0 to 2.24.0 in /java (#39452) ### Rationale for this change This is a draft PR for fixing the dependabot PR https://github.com/apache/arrow/pull/39409 ### What changes are included in this PR? Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. ### Are these changes tested? N/A. CIs are implicitly testing this including existing test cases. ### Are there any user-facing changes? No Lead-authored-by: vibhatha <vibhatha@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: David Li <li.davidm96@gmail.com> --- java/pom.xml | 4 ++-- .../apache/arrow/vector/complex/writer/TestComplexWriter.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/java/pom.xml b/java/pom.xml index 522ee4abc7669..fae072018eb19 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -44,7 +44,7 @@ <forkCount>2</forkCount> <checkstyle.failOnViolation>true</checkstyle.failOnViolation> <errorprone.javac.version>9+181-r4173-1</errorprone.javac.version> - <error_prone_core.version>2.22.0</error_prone_core.version> + <error_prone_core.version>2.24.0</error_prone_core.version> <maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version> <mockito.core.version>5.5.0</mockito.core.version> <mockito.inline.version>5.2.0</mockito.inline.version> @@ -844,7 +844,7 @@ <path> <groupId>com.google.errorprone</groupId> <artifactId>error_prone_core</artifactId> - <version>2.4.0</version> + <version>2.10.0</version> </path> </annotationProcessorPaths> </configuration> diff --git a/java/vector/src/test/java/org/apache/arrow/vector/complex/writer/TestComplexWriter.java b/java/vector/src/test/java/org/apache/arrow/vector/complex/writer/TestComplexWriter.java index 96d39e85f1f4a..e03ce0c056bf1 100644 --- a/java/vector/src/test/java/org/apache/arrow/vector/complex/writer/TestComplexWriter.java +++ b/java/vector/src/test/java/org/apache/arrow/vector/complex/writer/TestComplexWriter.java @@ -773,7 +773,7 @@ public void simpleUnion() throws Exception { for (int i = 0; i < COUNT; i++) { unionReader.setPosition(i); if (i % 5 == 0) { - Assert.assertEquals(i, i, unionReader.readInteger()); + Assert.assertEquals(i, unionReader.readInteger().intValue()); } else if (i % 5 == 1) { NullableTimeStampMilliTZHolder holder = new NullableTimeStampMilliTZHolder(); unionReader.read(holder);