-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow slash-delimited paths #21
Comments
Is it a configuration / opt-in thing to support both |
I'd strongly prefer this to be "always allow both" so that anyone receiving a I'd also be open to an alternative approach that allows One other potential approach could be setting the allowed delimiters in the constructor as an optional second parameter. This doesn't alleviate my primary concern but it would be a workable solution I could live with :) I would not be in favor of something that configures this behavior statically as I'd like some level of guarantee that other code can't modify the settings globally in a way that could prevent Open to your thoughts here! |
@simensen I have implemented both possible approaches for your review:
I'd appreciate any feedback you might have. And if/when you choose to merge one, please make sure to only merge one and close the other 😉 |
I am closing this as I think the merging of #24 resolves this issue. |
I'd like to use this library in the next major release of
league/commonmark
. Unfortunately I'm blocked by the fact that v1 of my library uses array paths with slashes (foo/bar
) instead of dots (foo.bar
) and I'd like to preserve that for backward-compatibility reasons.I'd therefore like to propose the ability for the library to allow for both
.
and/
as key path delimiters.I have working code I'd be happy to contribute, but it would rely on
#18 (merged)and #20 to be merged first to avoid merge conflicts.The text was updated successfully, but these errors were encountered: