diff --git a/CHANGELOG-Nns-Dapp-unreleased.md b/CHANGELOG-Nns-Dapp-unreleased.md index 6ccbf451a5d..f7f641c3026 100644 --- a/CHANGELOG-Nns-Dapp-unreleased.md +++ b/CHANGELOG-Nns-Dapp-unreleased.md @@ -15,31 +15,18 @@ proposal is successful, the changes it released will be moved from this file to #### Added -* Close modal on ESC key press. -* Add `ENABLE_ACTIONABLE_TAB` feature flag. -* Support `ApiBoundaryNodes` in `FirewallRulesScope` of `AddFirewallRulesPayload`. -* Support `SubnetRental` topic. -* Support NNS function 52 for `SubnetRentalRequest`. * Get `ckUSDC` canister IDs from environment/configuration. #### Changed -* Update IC, Candid, and `ic-cdk` dependencies. -* Changed support for NNS function 43 from `AddApiBoundaryNodePayload` (singular) to `AddApiBoundaryNodesPayload` (plural). * Set `Actionable Proposals` as the default selection. #### Deprecated #### Removed -* Stop encoding the accounts map in the `AccountsStore`. -* Removed `ENABLE_HIDE_ZERO_BALANCE` feature flag. -* Proposal filtering by reward status. -* Intermediate step to remove transactions from accounts stored in nns-dapp. - #### Fixed -* Successful swap message should not be shown when participant count is insufficient. * Rendering tokens with fewer than 8 decimals. * Don't allow inputting more decimals than the token supports. @@ -53,15 +40,11 @@ proposal is successful, the changes it released will be moved from this file to #### Added -* Added workflow to update IC cargo dependencies. * Include `ckUSDC` when generating `args.did` and `.env`. * Include `ckUSDC` canister IDs when importing from URL with `scripts/canister_ids`. #### Changed -* In `migration-test`, also populate some accounts between upgrade and downgrade. -* Update `dfx` version from 0.15.3 to 0.19.0. - #### Deprecated #### Removed diff --git a/CHANGELOG-Nns-Dapp.md b/CHANGELOG-Nns-Dapp.md index f62683a7275..fc4baf310b4 100644 --- a/CHANGELOG-Nns-Dapp.md +++ b/CHANGELOG-Nns-Dapp.md @@ -11,6 +11,45 @@ The NNS Dapp is released through proposals in the Network Nervous System. Theref Unreleased changes are added to `CHANGELOG-Nns-Dapp-unreleased.md` and moved here after a successful release. +## Proposal 129748 + +### Application + +#### Added + +* Close modal on ESC key press. +* Add `ENABLE_ACTIONABLE_TAB` feature flag. +* Support `ApiBoundaryNodes` in `FirewallRulesScope` of `AddFirewallRulesPayload`. +* Support `SubnetRental` topic. +* Support NNS function 52 for `SubnetRentalRequest`. + +#### Changed + +* Update IC, Candid, and `ic-cdk` dependencies. +* Changed support for NNS function 43 from `AddApiBoundaryNodePayload` (singular) to `AddApiBoundaryNodesPayload` (plural). + +#### Removed + +* Stop encoding the accounts map in the `AccountsStore`. +* Removed `ENABLE_HIDE_ZERO_BALANCE` feature flag. +* Proposal filtering by reward status. +* Intermediate step to remove transactions from accounts stored in nns-dapp. + +#### Fixed + +* Successful swap message should not be shown when participant count is insufficient. + +### Operations + +#### Added + +* Added workflow to update IC cargo dependencies. + +#### Changed + +* In `migration-test`, also populate some accounts between upgrade and downgrade. +* Update `dfx` version from 0.15.3 to 0.19.0. + ## Proposal 129618 ### Application diff --git a/Cargo.lock b/Cargo.lock index dd71dd4ef7a..445f2bf859a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3893,7 +3893,7 @@ checksum = "e4a24736216ec316047a1fc4252e27dabb04218aa4a3f37c6e7ddbf1f9782b54" [[package]] name = "nns-dapp" -version = "2.0.76" +version = "2.0.77" dependencies = [ "anyhow", "base64 0.21.5", @@ -4462,7 +4462,7 @@ dependencies = [ [[package]] name = "proposals" -version = "2.0.76" +version = "2.0.77" dependencies = [ "anyhow", "candid 0.10.8", @@ -5315,7 +5315,7 @@ checksum = "a507befe795404456341dfab10cef66ead4c041f62b8b11bbb92bffe5d0953e0" [[package]] name = "sns_aggregator" -version = "2.0.76" +version = "2.0.77" dependencies = [ "anyhow", "base64 0.21.5", diff --git a/Cargo.toml b/Cargo.toml index c594460387b..5d74c8bcade 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -7,7 +7,7 @@ members = [ resolver = "2" [workspace.package] -version = "2.0.76" +version = "2.0.77" [workspace.dependencies] ic-cdk = "0.13.3" diff --git a/frontend/package-lock.json b/frontend/package-lock.json index 177c32f48c9..0b70a39fa3e 100644 --- a/frontend/package-lock.json +++ b/frontend/package-lock.json @@ -1,12 +1,12 @@ { "name": "@dfinity/nns-dapp", - "version": "2.0.76", + "version": "2.0.77", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@dfinity/nns-dapp", - "version": "2.0.76", + "version": "2.0.77", "license": "SEE LICENSE IN LICENSE.md", "dependencies": { "@dfinity/agent": "^1.3.0", diff --git a/frontend/package.json b/frontend/package.json index 99979185534..4914438840f 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -1,6 +1,6 @@ { "name": "@dfinity/nns-dapp", - "version": "2.0.76", + "version": "2.0.77", "private": true, "license": "SEE LICENSE IN LICENSE.md", "scripts": { diff --git a/scripts/nns-dapp/release-sop b/scripts/nns-dapp/release-sop index 8aa82a44be1..78e49cafcc4 100755 --- a/scripts/nns-dapp/release-sop +++ b/scripts/nns-dapp/release-sop @@ -438,7 +438,7 @@ confirm_cmd git push origin -f tags/release-candidate record "Security test: npm audit" npm_audit verify "Security test: npm audit" "Expected npm audit" echo "found 0 vulnerabilities" record "Security test: cargo audit" cargo_audit -verify "Security test: cargo audit" "Expected cargo audit" echo "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336" +verify "Security test: cargo audit" "Expected cargo audit" echo "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336" record "Security test: no HTML in templates" no_html_in_templates confirm_cmd "$SOURCE_DIR/download-ci-wasm" --commit tags/release-candidate --dir "$TOP_DIR/release/ci" --wasm-filename nns-dapp.wasm.gz record "CI NNS-dapp WASM hash" "$SOURCE_DIR/get-hash-from-ci-log" --commit tags/release-candidate diff --git a/scripts/nns-dapp/release-sop-test-continue-after-success.json b/scripts/nns-dapp/release-sop-test-continue-after-success.json index be758d70d4f..85e19372ffa 100644 --- a/scripts/nns-dapp/release-sop-test-continue-after-success.json +++ b/scripts/nns-dapp/release-sop-test-continue-after-success.json @@ -72,8 +72,8 @@ "git push origin -f tags/release-candidate: Was already done. Skipping.", "Security test: npm audit: Was already: \u001b[35mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: found 0 vulnerabilities", - "Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "Security test: no HTML in templates: Was already: \u001b[35mChecked\u001b[0m", "scripts/nns-dapp/download-ci-wasm --commit tags/release-candidate --dir /home/runner/work/nns-dapp/release/ci --wasm-filename nns-dapp.wasm.gz: Was already done. Skipping.", "CI NNS-dapp WASM hash: Was already: \u001b[35m6fbaddd1b8fde76de97ca1b03a356f01741878d6210cd9b7c6753ae80ae374a4\u001b[0m", diff --git a/scripts/nns-dapp/release-sop-test-continue-different-staging-canister.json b/scripts/nns-dapp/release-sop-test-continue-different-staging-canister.json index c83cde15b8f..87c3c98d7a1 100644 --- a/scripts/nns-dapp/release-sop-test-continue-different-staging-canister.json +++ b/scripts/nns-dapp/release-sop-test-continue-different-staging-canister.json @@ -60,8 +60,8 @@ "git push origin -f tags/release-candidate: Was already done. Skipping.", "Security test: npm audit: Was already: \u001b[35mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: found 0 vulnerabilities", - "Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "Security test: no HTML in templates: Was already: \u001b[35mChecked\u001b[0m", "scripts/nns-dapp/download-ci-wasm --commit tags/release-candidate --dir /home/runner/work/nns-dapp/release/ci --wasm-filename nns-dapp.wasm.gz: Was already done. Skipping.", "CI NNS-dapp WASM hash: Was already: \u001b[35m6fbaddd1b8fde76de97ca1b03a356f01741878d6210cd9b7c6753ae80ae374a4\u001b[0m", diff --git a/scripts/nns-dapp/release-sop-test-different-built-args-hash.json b/scripts/nns-dapp/release-sop-test-different-built-args-hash.json index 6903a439e51..17b77261e3d 100644 --- a/scripts/nns-dapp/release-sop-test-different-built-args-hash.json +++ b/scripts/nns-dapp/release-sop-test-different-built-args-hash.json @@ -63,7 +63,7 @@ }, { "command": "cargo_audit", - "stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "stderr": "", "exitCode": 0 }, @@ -194,8 +194,8 @@ "git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m", "Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", - "Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", "Security test: no HTML in templates: \u001b[32mChecked\u001b[0m", "👇 Press enter to run the following command:", "", diff --git a/scripts/nns-dapp/release-sop-test-different-built-wasm-hash.json b/scripts/nns-dapp/release-sop-test-different-built-wasm-hash.json index 07cee04e9bb..03706191c0b 100644 --- a/scripts/nns-dapp/release-sop-test-different-built-wasm-hash.json +++ b/scripts/nns-dapp/release-sop-test-different-built-wasm-hash.json @@ -63,7 +63,7 @@ }, { "command": "cargo_audit", - "stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "stderr": "", "exitCode": 0 }, @@ -164,8 +164,8 @@ "git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m", "Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", - "Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", "Security test: no HTML in templates: \u001b[32mChecked\u001b[0m", "👇 Press enter to run the following command:", "", diff --git a/scripts/nns-dapp/release-sop-test-different-cargo-audit.json b/scripts/nns-dapp/release-sop-test-different-cargo-audit.json index 0bfbe1e5f74..45850766943 100644 --- a/scripts/nns-dapp/release-sop-test-different-cargo-audit.json +++ b/scripts/nns-dapp/release-sop-test-different-cargo-audit.json @@ -103,7 +103,7 @@ "Security test: cargo audit: \u001b[32mRUSTSEC-1999-0001\u001b[0m", "Values don't match!", "Security test: cargo audit: RUSTSEC-1999-0001", - "Expected cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336" + "Expected cargo audit: RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336" ], "expectedExitCode": 1 } diff --git a/scripts/nns-dapp/release-sop-test-different-staging-wasm-hash.json b/scripts/nns-dapp/release-sop-test-different-staging-wasm-hash.json index be062c3622d..4e383e73f81 100644 --- a/scripts/nns-dapp/release-sop-test-different-staging-wasm-hash.json +++ b/scripts/nns-dapp/release-sop-test-different-staging-wasm-hash.json @@ -63,7 +63,7 @@ }, { "command": "cargo_audit", - "stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "stderr": "", "exitCode": 0 }, @@ -146,8 +146,8 @@ "git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m", "Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", - "Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", "Security test: no HTML in templates: \u001b[32mChecked\u001b[0m", "👇 Press enter to run the following command:", "", diff --git a/scripts/nns-dapp/release-sop-test-different-wasm-hash.json b/scripts/nns-dapp/release-sop-test-different-wasm-hash.json index 07236434135..88fa756d5df 100644 --- a/scripts/nns-dapp/release-sop-test-different-wasm-hash.json +++ b/scripts/nns-dapp/release-sop-test-different-wasm-hash.json @@ -59,7 +59,7 @@ }, { "command": "cargo_audit", - "stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "stderr": "", "exitCode": 0 }, @@ -118,8 +118,8 @@ "git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m", "Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", - "Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", "Security test: no HTML in templates: \u001b[32mChecked\u001b[0m", "👇 Press enter to run the following command:", "", diff --git a/scripts/nns-dapp/release-sop-test-html-in-template.json b/scripts/nns-dapp/release-sop-test-html-in-template.json index 482c74f718e..57c14f55051 100644 --- a/scripts/nns-dapp/release-sop-test-html-in-template.json +++ b/scripts/nns-dapp/release-sop-test-html-in-template.json @@ -59,7 +59,7 @@ }, { "command": "cargo_audit", - "stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "stderr": "", "exitCode": 0 }, @@ -106,8 +106,8 @@ "git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m", "Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", - "Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", "Security test: no HTML in templates: Failed" ], "expectedExitCode": 1 diff --git a/scripts/nns-dapp/release-sop-test-successful-release.json b/scripts/nns-dapp/release-sop-test-successful-release.json index c0a5ddf330a..666de43e776 100644 --- a/scripts/nns-dapp/release-sop-test-successful-release.json +++ b/scripts/nns-dapp/release-sop-test-successful-release.json @@ -63,7 +63,7 @@ }, { "command": "cargo_audit", - "stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", + "stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336", "stderr": "", "exitCode": 0 }, @@ -194,8 +194,8 @@ "git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m", "Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", "Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m", - "Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", - "Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", + "Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m", "Security test: no HTML in templates: \u001b[32mChecked\u001b[0m", "👇 Press enter to run the following command:", "",