Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter doesn't like the PKCE code in handlers.go #1844

Closed
al45tair opened this issue Oct 26, 2020 · 1 comment · Fixed by #1845
Closed

Linter doesn't like the PKCE code in handlers.go #1844

al45tair opened this issue Oct 26, 2020 · 1 comment · Fixed by #1845

Comments

@al45tair
Copy link
Contributor

I'm seeing this:

curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | BINARY=golangci-lint bash -s -- v1.31.0
golangci/golangci-lint info checking GitHub for tag 'v1.31.0'
golangci/golangci-lint info found version: 1.31.0 for v1.31.0/linux/amd64
golangci/golangci-lint info installed ./bin/golangci-lint
bin/golangci-lint run
Error: server/handlers.go:837:2: ifElseChain: rewrite if-else to switch statement (gocritic)
	if providedCodeVerifier != "" && codeChallengeFromStorage != "" {
	^
make: *** [lint] Error 1
Error: Makefile:70: recipe for target 'lint' failed
Error: Process completed with exit code 2.
@nabokihms
Copy link
Member

nabokihms commented Oct 26, 2020

I will fix it because I'm the last who changed lint rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants