Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples to a separate repo or module #1740

Closed
sagikazarmark opened this issue Jun 30, 2020 · 4 comments · Fixed by #1764
Closed

Move examples to a separate repo or module #1740

sagikazarmark opened this issue Jun 30, 2020 · 4 comments · Fixed by #1764
Assignees

Comments

@sagikazarmark
Copy link
Member

Make sure that examples does not pull in extra dependencies into the project.

@sagikazarmark sagikazarmark self-assigned this Jun 30, 2020
@sagikazarmark
Copy link
Member Author

@JoelSpeed @bonifaido what do you think would be better? A separate repository or separate modules in the main repository.

I'm leaning towards one of those options, but wanted to hear your opinion as well.

@JoelSpeed
Copy link
Contributor

I don't see any reason not to make them separate modules, would be easier for people to find at least. A second repo would be harder to get started with them right?

@sagikazarmark
Copy link
Member Author

Yes, separate modules are easier to find and easier to keep updated, but separate repos are easier to clone and we can avoid the module hell in the main repo.

I'd start with separate module though (if it works). We can always move stuff to separate repo if necessary.

@bonifaido
Copy link
Member

I'm a fan of the "same repo, different module" approach too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants