Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit vendoring #1597

Closed
sagikazarmark opened this issue Dec 6, 2019 · 2 comments · Fixed by #1745
Closed

Revisit vendoring #1597

sagikazarmark opened this issue Dec 6, 2019 · 2 comments · Fixed by #1745
Labels
area/dx

Comments

@sagikazarmark
Copy link
Member

As far as I can tell, neither the current build process nor the docker build use the vendored dependencies.

While vendoring has certain advantages, it definitely has some disadvantages too and if it's not used at all I question its validity. (Yeah, I'm generally against vendoring).
@sagikazarmark sagikazarmark mentioned this issue Jun 30, 2020
Merged
@JoelSpeed
Copy link
Contributor

+1 I'm also not a fan of vendoring and don't really see much value added here

@sagikazarmark
Copy link
Member Author

Let's get rid of it then. PR incoming.

@sagikazarmark sagikazarmark mentioned this issue Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove vendor dexidp/dex
2 participants
@sagikazarmark @JoelSpeed