You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when org filtering is enabled in the GitHub connector organizations without teams are skipped from the returned groups scope. Example configuration, which returns (my-org has no teams defined) an empty groups: [] list in the ID token:
loadAllGroups: trueorgs:
- name: my-org
The code which does this filtering:
// User is in at least one org. User is authorized if no teams are specified// in config; include all teams in the claim. Otherwise, filter out teams not in// 'teams' list in config.iflen(org.Teams) ==0 {
inOrgNoTeams=true
} elseifteams=groups_pkg.Filter(teams, org.Teams); len(teams) ==0 {
c.logger.Infof("github: user %q in org %q but no teams", userName, org.Name)
}
for_, teamName:=rangeteams {
groups=append(groups, formatTeamName(org.Name, teamName))
}
I think it would be a good idea to append the organization without the :teamName suffix as well instead of the inOrgNoTeams = true code block. What is the reason behind this filtering? Any thoughts?
The text was updated successfully, but these errors were encountered:
bonifaido
changed the title
Question/Proposal: GitHub orgs not returned without teams in orgs when filtering
Question/Proposal: GitHub orgs without teams are not returned in case of filtering
Sep 24, 2019
Currently, when org filtering is enabled in the GitHub connector organizations without teams are skipped from the returned
groups
scope. Example configuration, which returns (my-org has no teams defined) an emptygroups: []
list in the ID token:The code which does this filtering:
I think it would be a good idea to append the organization without the
:teamName
suffix as well instead of theinOrgNoTeams = true
code block. What is the reason behind this filtering? Any thoughts?The text was updated successfully, but these errors were encountered: