Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapup for Jira #188

Closed
groenborg opened this issue Aug 14, 2017 · 10 comments
Closed

Wrapup for Jira #188

groenborg opened this issue Aug 14, 2017 · 10 comments

Comments

@groenborg
Copy link
Collaborator

groenborg commented Aug 14, 2017

When issues are delivered with a #close in the commit message, the issues should be closed automatically, as it does in GitHub.

Jira supports smart commit, so this feature is already implemented, it just needs to be tested to see if it works, and if not how the smart commits are enabled.

@lakruzz
Copy link
Contributor

lakruzz commented Aug 14, 2017

We need JIRA to be able to do something similar to this: https://help.github.com/articles/closing-issues-using-keywords/

If it doesn't exist, we will have to implement it.

@lakruzz
Copy link
Contributor

lakruzz commented Aug 14, 2017

@lakruzz
Copy link
Contributor

lakruzz commented Aug 14, 2017

...ooops seems to be relevant for bitbucket cloud - we need this to work in an on-premises setup too.

@lakruzz
Copy link
Contributor

lakruzz commented Aug 14, 2017

@hoeghh @praqmaTim ?

@TheDukeDK
Copy link

@groenborg
Copy link
Collaborator Author

Smart commit are only support is you use the Suite which means BitBucket and Jira. That does not present a problem however since it matches the SoW.

@groenborg
Copy link
Collaborator Author

This feature is complete separated from everything. So nothing needs to be changed unless line endings are a problem, which is an easy fix. I will therefore resize the issue

@buep
Copy link
Contributor

buep commented Sep 6, 2017

If possible within the new size - add a test for the line endings if we have the test mechanisms for it - else leave it for the test strategy, but mention it on our combinatorial drawing.

@groenborg
Copy link
Collaborator Author

@buep I do not think it is necessary, because we found a way to let go decide the line endings based on the OS if I remember correctly, so this is more about figuring out if we also added that feature to this command. However I think you are right and we need a test if that is not the case

@buep
Copy link
Contributor

buep commented Sep 6, 2017

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants