feat: .add directives folder and add lazyimg dir fearture #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-hbs-admin ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hongbusi
reviewed
Apr 29, 2022
src/directives/index.ts
Outdated
| * Coonfigure and register global directives | ||
| */ | ||
|
|
||
| import { App } from 'vue' |
There was a problem hiding this comment.
我写的时候写了的,好像PrettierStandard自动保存给我优化掉了====,我换成了Prettier Eslint就可以了
src/directives/lazyImg.ts
Outdated
| app.directive('lazyImg', authDirective) | ||
| } | ||
|
|
||
| export default authDirective |
There was a problem hiding this comment.
- authDirective 命名需要优化；
- 方法比较简单时，不用拆方法；
- 默认图片可以替换一下；
There was a problem hiding this comment.
1.命名可以改一下,
2.方法这个我看了下主要是因为嵌套函数,另外步骤更加细致和语义化的问题,这个问题应该不大
3.图片的话我就用test那张吧,名字还是default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create directives folder and add a lazyImg_dir by vueuse/core API;in this folder, you can add any dir_fearture; you just need to add a 'v-dir' instruction on the correspoding HTML when you want to get the correspoding effect
close #34
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).