Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification of custom artifact glob in @typechain/hardhat #730

Open
ckoopmann opened this issue Jun 22, 2022 · 2 comments
Open

Allow specification of custom artifact glob in @typechain/hardhat #730

ckoopmann opened this issue Jun 22, 2022 · 2 comments

Comments

@ckoopmann
Copy link

ckoopmann commented Jun 22, 2022

Currently the glob to match build artifacts for which to generate types is hardcoded here.

While the user can specify additional globs for "externalArtifacts" there is no way to disable type generation for selected contracts/artifacts.
One example where this is a problem is, if the user has multiple contracts with the same name which leads to Duplicate Identifier typescript errors.

Adding an optional config parameter to change the hardcoded glob (with the current pattern as the default) would fix this issue.

@ckoopmann
Copy link
Author

Fwiw: I'd be more than happy to implement this, if it's deemed a desirable feature. As far as I can see it should be done in just a few lines of code.

@ckoopmann
Copy link
Author

Went ahead and implemented this in #735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant