Skip to content

Commit 1bfc8ac

Browse files
committed
ci: Fix dockerhub image name
Fix variable setting DOCKERHUB_LC_IMAGE_NAME Bump version on overlooked dockerhub login action Quote some unquoted variables [#patch]
1 parent 5a178de commit 1bfc8ac

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

.github/workflows/release.yml

+11-8
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ jobs:
2525
steps:
2626
- name: work around github's inability to add a lowercase() function
2727
run: |
28-
echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> $GITHUB_ENV
28+
echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> "$GITHUB_ENV"
2929
- name: Set up QEMU
3030
uses: docker/setup-qemu-action@v2
3131
- name: Set up Docker Buildx
3232
uses: docker/setup-buildx-action@v2
3333
#- name: Log in to GitHub Container Registry
34-
# uses: docker/login-action@v2
34+
# uses: docker/login-action@v2.1.0
3535
# with:
3636
# registry: ghcr.io
3737
# username: ${{ github.repository_owner }}
@@ -63,7 +63,7 @@ jobs:
6363
steps:
6464
- name: work around github's inability to add a lowercase() function
6565
run: |
66-
echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> $GITHUB_ENV
66+
echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> "$GITHUB_ENV"
6767
- name: Download artifact
6868
uses: actions/download-artifact@v3
6969
with:
@@ -88,7 +88,7 @@ jobs:
8888
steps:
8989
- name: work around github's inability to add a lowercase() function
9090
run: |
91-
echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> $GITHUB_ENV
91+
echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> "$GITHUB_ENV"
9292
- name: Download artifact
9393
uses: actions/download-artifact@v3
9494
with:
@@ -117,8 +117,11 @@ jobs:
117117
steps:
118118
- name: work around github's inability to add a lowercase() function
119119
run: |
120-
echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> $GITHUB_ENV
121-
echo "DOCKERHUB_LC_IMAGE_NAME=${LC_IMAGE_NAME/*\//${DOCKERHUB_USERNAME,,}/}" >> $GITHUB_ENV
120+
DOCKERHUB_IMAGE_NAME=${IMAGE_NAME/*\//${DOCKERHUB_USERNAME,,}/}
121+
{
122+
printf 'LC_IMAGE_NAME=%s\n' "${IMAGE_NAME,,}"
123+
printf 'DOCKERHUB_LC_IMAGE_NAME=%s\n' "${DOCKERHUB_IMAGE_NAME,,}"
124+
} >> "$GITHUB_ENV"
122125
123126
# create the release
124127
- name: Checkout
@@ -170,13 +173,13 @@ jobs:
170173
- name: Set up Docker Buildx
171174
uses: docker/setup-buildx-action@v2
172175
- name: Log in to GitHub Container Registry
173-
uses: docker/login-action@v2
176+
uses: docker/login-action@v2.1.0
174177
with:
175178
registry: ghcr.io
176179
username: ${{ github.repository_owner }}
177180
password: ${{ secrets.GITHUB_TOKEN }}
178181
- name: Login to DockerHub
179-
uses: docker/login-action@v1.14.1
182+
uses: docker/login-action@v2.1.0
180183
with:
181184
username: ${{ secrets.DOCKERHUB_USERNAME }}
182185
password: ${{ secrets.DOCKERHUB_PUBLISH_TOKEN }}

0 commit comments

Comments
 (0)