Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Use disambiguated interface names #36

Closed
efritz opened this issue Sep 29, 2022 · 0 comments · Fixed by #37
Closed

config: Use disambiguated interface names #36

efritz opened this issue Sep 29, 2022 · 0 comments · Fixed by #37
Assignees

Comments

@efritz
Copy link
Member

efritz commented Sep 29, 2022

- filename: internal/codeintel/uploads/mocks_test.go
  sources:
    - path: github.com/sourcegraph/sourcegraph/internal/codeintel/uploads/internal/store
      interfaces:
        - Store
    - path: github.com/sourcegraph/sourcegraph/internal/codeintel/uploads/internal/lsifstore
      interfaces:
        - LSIFStore
    - path: github.com/sourcegraph/sourcegraph/internal/codeintel/uploads
      interfaces:
        - GitserverClient
    - path: github.com/sourcegraph/sourcegraph/internal/workerutil/dbworker/store
      interfaces:
        - Store
      prefix: Worker

This is currently illegal, although it would generate non-conflicting code. This should be accepted when using non-command-line flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant