Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to define weekStartsOn parameter #4

Open
binarykitchen opened this issue Feb 24, 2022 · 1 comment · May be fixed by #7
Open

Unable to define weekStartsOn parameter #4

binarykitchen opened this issue Feb 24, 2022 · 1 comment · May be fixed by #7
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@binarykitchen
Copy link

binarykitchen commented Feb 24, 2022 •
edited by derhuerst
Loading

Some countries might start the week on another day, which can be configured in date-fns weekStartsOn parameter.

Unfortunately, this cannot be passed over here due to fixed lexing:

parse-human-relative-time/date-fns.js

Line 18 in 1fd2193

res = dateFns[cmd](res, ...args)

Can we figure a way, a solution, how to support such a parameter?
@derhuerst derhuerst added enhancement New feature or request help wanted Extra attention is needed labels Mar 15, 2022
@derhuerst
Copy link
Owner

Huh, this is a tricky problem.

Without trying it out, I think the best way is to

  1. add an optional opt = {} to createParse
  2. const {weekStartsOn} = {weekStartsOn: 0, ...opt}
  3. if cmd is a date-fns command where the weekStartsOn option is accepted, pass it into args via args = [...args, {weekStartsOn}].

PR welcome!

@binarykitchen binarykitchen linked a pull request Apr 12, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds support for weekStartsOn and prettier config binarykitchen/parse-human-relative-time
2 participants
@binarykitchen @derhuerst