Better explain the test is also verifying the metadata

Co-authored-by: David Rodriguez <[email protected]>

Author: mctofu

npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker_spec.rb

@@ -1363,18 +1363,18 @@
 
     # Dependency doesn't consider metadata as part of equality checks
     # so this allows us to check that the metadata is updated in tests.
-    RSpec::Matchers.define :with_metadata do |expected|
+    RSpec::Matchers.define :including_metadata do |expected|
       match do |actual|
         actual == expected && actual.metadata == expected.metadata
       end
     end
 
-    def contain_exactly_with_metadata(*expected)
-      contain_exactly(*expected.map { |e| with_metadata(e) })
+    def contain_exactly_including_metadata(*expected)
+      contain_exactly(*expected.map { |e| including_metadata(e) })
     end
 
-    def eq_with_metadata(expected_array)
-      eq(expected_array).and contain_exactly_with_metadata(*expected_array)
+    def eq_including_metadata(expected_array)
+      eq(expected_array).and contain_exactly_including_metadata(*expected_array)
     end
 
     context "for a security update for a locked transitive dependency" do
@@ -1401,7 +1401,7 @@ def eq_with_metadata(expected_array)
 
       it "correctly updates the transitive dependency" do
         expect(checker.send(:updated_dependencies_after_full_unlock)).
-          to eq_with_metadata([
+          to eq_including_metadata([
             Dependabot::Dependency.new(
               name: "@dependabot-fixtures/npm-transitive-dependency",
               version: "1.0.1",
@@ -1443,7 +1443,7 @@ def eq_with_metadata(expected_array)
         let(:registry_listing_url) { "https://registry.npmjs.org/transitive-dependency-locked-by-intermediate" }
 
         it "correctly updates the transitive dependency" do
-          expect(checker.send(:updated_dependencies_after_full_unlock)).to eq_with_metadata([
+          expect(checker.send(:updated_dependencies_after_full_unlock)).to eq_including_metadata([
             Dependabot::Dependency.new(
               name: "@dependabot-fixtures/npm-transitive-dependency",
               package_manager: "npm_and_yarn",
@@ -1470,7 +1470,7 @@ def eq_with_metadata(expected_array)
         let(:registry_listing_url) { "https://registry.npmjs.org/transitive-dependency-locked-by-multiple" }
 
         it "correctly updates the transitive dependency" do
-          expect(checker.send(:updated_dependencies_after_full_unlock)).to contain_exactly_with_metadata(
+          expect(checker.send(:updated_dependencies_after_full_unlock)).to contain_exactly_including_metadata(
             Dependabot::Dependency.new(
               name: "@dependabot-fixtures/npm-parent-dependency",
               package_manager: "npm_and_yarn",
@@ -1566,7 +1566,7 @@ def eq_with_metadata(expected_array)
         end
 
         it "correctly updates the parent dependency and removes the transitive because removal is enabled" do
-          expect(checker.send(:updated_dependencies_after_full_unlock)).to contain_exactly_with_metadata(
+          expect(checker.send(:updated_dependencies_after_full_unlock)).to contain_exactly_including_metadata(
             Dependabot::Dependency.new(
               name: "@dependabot-fixtures/npm-transitive-dependency",
               package_manager: "npm_and_yarn",
@@ -1628,7 +1628,7 @@ def eq_with_metadata(expected_array)
         end
 
         it "correctly updates the transitive dependency by unlocking the parent" do
-          expect(checker.send(:updated_dependencies_after_full_unlock)).to eq_with_metadata([
+          expect(checker.send(:updated_dependencies_after_full_unlock)).to eq_including_metadata([
             Dependabot::Dependency.new(
               name: "@dependabot-fixtures/npm-transitive-dependency-with-more-versions",
               package_manager: "npm_and_yarn",