Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508-defect-2 [SEMANTIC MARKUP]: Links SHOULD not have title attributes #11843

Open
2 tasks
Tracked by #13563
jenstrickland opened this issue Jul 13, 2020 · 6 comments
Open
2 tasks
Tracked by #13563
Labels
a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints accessibility Issues related to accessibility CMS Team CMS Product team that manages both editor exp and devops

Comments

@jenstrickland
Copy link

jenstrickland commented Jul 13, 2020

508-defect-2

Description

Still an issue in D10

There are links within page content of the Erie VAMC site that have title attributes. These should be removed as they will interfere with screen readers.

Acceptance Criteria

  • For every <a href="… there should not be a title="text".
  • Accessibility review

Steps to Recreate

  1. Go to the Erie medical Center page
  2. Hover over "Learn more about DAV and the other van services available in your county" link
  3. Verify that a small "tool tip" like bit of text appears

Additional Context

  • This title attribute is not being added manually by the editor, I confirmed in the CMS
    Screenshot of Link in the Rich text editor - there is no title:
    image

Screenshot of the View node - now there is a title:
image

  • It's also odd that every link on this node is not getting a title, none of these have it:
    image

  • This is also not just happening on Facilities pages, I have an issue of this occurring very recently on a Benefits page:
    image

Previous Team Points

8

@jenstrickland jenstrickland added accessibility Issues related to accessibility vsa a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints labels Jul 13, 2020
@jenstrickland jenstrickland changed the title [SEMANTIC MARKUP]: Links SHOULD not have title attributes 508-defect-2 [SEMANTIC MARKUP]: Links SHOULD not have title attributes Sep 8, 2020
@laflannery laflannery removed the vsa label Dec 7, 2022
@laflannery laflannery transferred this issue from department-of-veterans-affairs/va.gov-team Dec 7, 2022
@laflannery laflannery added Facilities Facilities products (VAMC, Vet Center, etc) CMS Team CMS Product team that manages both editor exp and devops and removed Facilities Facilities products (VAMC, Vet Center, etc) labels Dec 7, 2022
@laflannery laflannery assigned edmund-dunn and unassigned SgardnerPMP Jan 4, 2023
@edmund-dunn
Copy link
Contributor

@laflannery this is a core issue. See https://www.drupal.org/project/drupal/issues/3083583

@laflannery
Copy link
Contributor

Brought this up to Mike so we can hopefully talk about/work through this at this months Drupal a11y office hours and get some momentum on this

@wesrowe wesrowe mentioned this issue Feb 1, 2023
36 tasks
@laflannery
Copy link
Contributor

laflannery commented Feb 16, 2023

Remove title - YES

  • Rain suggests if starting with the smaller approach, include helpful information that explains why

Laura added that their module (probably Linkit) is auto adding the title from the destination node

  • There might be a setting where we can turn this off, Plugin settings

Some helpful drupaly things:

If we have to make a patch for this too: Have to think about both the specific project, and others who have legacy content created with less knowledge

@edmund-dunn
Copy link
Contributor

File is:
docroot/core/lib/Drupal/Core/Link.php

@productmike
Copy link

productmike commented Jul 3, 2023

During refinement on 6/30, the team discussed how to break this 13 point ticket down into smaller chunks. We will be doing this by having this ticket representing the discovery and fix work. There will be a 2nd ticket (#14244) that tracks the drupal community feedback loops -- both the timing for feedback AND the lift for the feedback are uncertainties. Therefore the story points for that 2nd story will start with a midpoint, but will likely change as more information is obtained.

FYI: @laflannery @edmund-dunn @tonytaylor @teeshe @BerniXiongA6

@srancour
Copy link
Contributor

Still an issue and should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints accessibility Issues related to accessibility CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

No branches or pull requests

6 participants