Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDD Style Tests Not Detected #793

Open
jherdman opened this issue Jan 22, 2023 · 9 comments
Open

BDD Style Tests Not Detected #793

jherdman opened this issue Jan 22, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request testing Running test using LSP

Comments

@jherdman
Copy link

Describe the bug

Nested tests are not detected.

To Reproduce

  1. Write a test file, and use the BDD style — make sure you nest your tests!
  2. Note the lack of green test running arrows
  3. De-nest (if you will) one of your examples. It now has a green arrow.

Expected behavior

It should work

Screenshots

Screenshot 2023-01-22 at 1 37 55 PM

Versions

vscode: 1.74.3
deno: 1.29.3
extension: 3.16.0

@jherdman
Copy link
Author

Further, a describe with nested cases (i.e. it) do not show green arrows either

@thomas3577
Copy link

Also the Testing Explorer does not find tests when BDD Styles is applied.

@jherdman
Copy link
Author

jherdman commented Mar 4, 2023

If someone is willing to guide me a little I'm happy to carve out some time to fix this.

@bartlomieju bartlomieju added bug Something isn't working design limitation testing Running test using LSP labels Jul 10, 2023
@pwalker
Copy link

pwalker commented Jul 11, 2023

I would also like it if bdd style tests worked a little better in vscode. I searched around a bit, and I wonder if issue is that the deno LSP doesn't return information about BDD-style tests. Looking at this page, the docs seem to indicate that the lsp server only returns tests & steps. I'm not sure how to query the lsp server directly to figure anything out, but I just thought I'd mention it in case it helps.

@gykf
Copy link

gykf commented Aug 9, 2023

In my case, it seems like BDD-style tests do eventually get picked up by the extension, however, when trying to run them they never finish, and they block the execution of the remaining tests.

Example video demonstration:
https://github.com/denoland/vscode_deno/assets/2887321/a058891e-8bb3-43d3-96e8-d31d0a3d64bc

@nayeemrmn nayeemrmn self-assigned this Aug 30, 2023
@nayeemrmn
Copy link
Collaborator

Since we have this in std, we should consider the LSP detecting describe()/it() out of the box.

@nayeemrmn nayeemrmn added enhancement New feature or request and removed bug Something isn't working labels Aug 30, 2023
@wojpawlik
Copy link

node:test also isn't detected

@krlwlfrt
Copy link

krlwlfrt commented Dec 4, 2024

Since we have this in std, we should consider the LSP detecting describe()/it() out of the box.

This is a very strong argument to support this.

@dandv
Copy link

dandv commented Dec 6, 2024

Hard to believe that as of 2025 (almost), Deno BDD tests can't be run individually in apparently any IDE - no VSCode forks, no IntelliJ/IDEA IDEs either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Running test using LSP
Projects
None yet
Development

No branches or pull requests

9 participants