From 6a60de991b3f93af8abb94265772aadf95da5228 Mon Sep 17 00:00:00 2001 From: crowlkats Date: Wed, 8 Jan 2025 17:18:29 +0100 Subject: [PATCH 1/2] fix: revert js_class_and_message_to_exception to just do TypeErrors --- core/error.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/core/error.rs b/core/error.rs index a0f329787..75124efb3 100644 --- a/core/error.rs +++ b/core/error.rs @@ -239,17 +239,18 @@ pub fn throw_js_error_class( fn js_class_and_message_to_exception<'s>( scope: &mut v8::HandleScope<'s>, - class: &str, + _class: &str, message: &str, ) -> v8::Local<'s, v8::Value> { let message = v8::String::new(scope, message).unwrap(); - match class { + /*match class { TYPE_ERROR => v8::Exception::type_error(scope, message), RANGE_ERROR => v8::Exception::range_error(scope, message), REFERENCE_ERROR => v8::Exception::reference_error(scope, message), SYNTAX_ERROR => v8::Exception::syntax_error(scope, message), _ => v8::Exception::error(scope, message), - } + }*/ + v8::Exception::type_error(scope, message) } pub fn to_v8_error<'a>( From 25ca2dd6310dda79a5229178c3ccee705530910a Mon Sep 17 00:00:00 2001 From: crowlkats Date: Wed, 8 Jan 2025 20:16:45 +0100 Subject: [PATCH 2/2] add comment --- core/error.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/error.rs b/core/error.rs index 75124efb3..e70e397a3 100644 --- a/core/error.rs +++ b/core/error.rs @@ -243,7 +243,11 @@ fn js_class_and_message_to_exception<'s>( message: &str, ) -> v8::Local<'s, v8::Value> { let message = v8::String::new(scope, message).unwrap(); - /*match class { + /* + commented out since this was previously only handling type errors, but this + change is breaking CLI, so visiting on a later date + + match class { TYPE_ERROR => v8::Exception::type_error(scope, message), RANGE_ERROR => v8::Exception::range_error(scope, message), REFERENCE_ERROR => v8::Exception::reference_error(scope, message),