From b76d29ab4556c668ed0a113e88fca6e8c9543052 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Fri, 31 Jan 2025 10:06:03 +0530 Subject: [PATCH 1/3] fix(ext/node): Set process.env as own property --- ext/node/polyfills/process.ts | 1 + tests/unit_node/process_test.ts | 2 ++ 2 files changed, 3 insertions(+) diff --git a/ext/node/polyfills/process.ts b/ext/node/polyfills/process.ts index e10f2d67d4a598..3e63b9a076d965 100644 --- a/ext/node/polyfills/process.ts +++ b/ext/node/polyfills/process.ts @@ -780,6 +780,7 @@ const process = new Process(); /* Set owned property */ process.versions = versions; +process.env = env; Object.defineProperty(process, Symbol.toStringTag, { enumerable: false, diff --git a/tests/unit_node/process_test.ts b/tests/unit_node/process_test.ts index 592bd6497fc956..8527edb6ebbb4b 100644 --- a/tests/unit_node/process_test.ts +++ b/tests/unit_node/process_test.ts @@ -390,6 +390,8 @@ Deno.test({ Deno.test({ name: "process.env", fn() { + assert(process.hasOwnProperty("env")); + Deno.env.set("HELLO", "WORLD"); assertObjectMatch(process.env, Deno.env.toObject()); From 8ee8fab544fb1f5bc0dbb699aae2342ef1506dc5 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Fri, 31 Jan 2025 10:11:35 +0530 Subject: [PATCH 2/3] lint --- tests/unit_node/process_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit_node/process_test.ts b/tests/unit_node/process_test.ts index 8527edb6ebbb4b..c740e7f72cf886 100644 --- a/tests/unit_node/process_test.ts +++ b/tests/unit_node/process_test.ts @@ -390,7 +390,7 @@ Deno.test({ Deno.test({ name: "process.env", fn() { - assert(process.hasOwnProperty("env")); + assert(Object.prototype.hasOwnProperty(process, "env")); Deno.env.set("HELLO", "WORLD"); From df1fee12e560f4f540b678408fff5401a7bbe0f6 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Fri, 31 Jan 2025 10:28:40 +0530 Subject: [PATCH 3/3] Update tests/unit_node/process_test.ts Co-authored-by: Yoshiya Hinosawa Signed-off-by: Divy Srivastava --- tests/unit_node/process_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit_node/process_test.ts b/tests/unit_node/process_test.ts index c740e7f72cf886..fe6f43b3e5b9c9 100644 --- a/tests/unit_node/process_test.ts +++ b/tests/unit_node/process_test.ts @@ -390,7 +390,7 @@ Deno.test({ Deno.test({ name: "process.env", fn() { - assert(Object.prototype.hasOwnProperty(process, "env")); + assert(Object.prototype.hasOwnProperty.call(process, "env")); Deno.env.set("HELLO", "WORLD");