From 83b67e50bc99e8c12ff3694ddd5de0eb8611072e Mon Sep 17 00:00:00 2001 From: Dj <43033058+DjDeveloperr@users.noreply.github.com> Date: Wed, 21 Jun 2023 12:48:44 +0530 Subject: [PATCH] fix(cli/napi): property with getter/setter always failed with `napi_define_properties` --- cli/napi/js_native_api.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/napi/js_native_api.rs b/cli/napi/js_native_api.rs index 900a50f40388ba..a3b519a5d01560 100644 --- a/cli/napi/js_native_api.rs +++ b/cli/napi/js_native_api.rs @@ -1559,7 +1559,7 @@ fn napi_define_properties( let define_maybe = object.define_property(scope, name, &desc); return_status_if_false!( env_ptr, - !define_maybe.unwrap_or(false), + define_maybe.is_some(), napi_invalid_arg ); } else if property.method.is_some() {